----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106520/#review19501 -----------------------------------------------------------
backends/virtuoso/virtuosomodel.cpp <http://git.reviewboard.kde.org/r/106520/#comment15497> how about throwing an error? backends/virtuoso/virtuosomodel.cpp <http://git.reviewboard.kde.org/r/106520/#comment15498> maybe also an error? backends/virtuoso/virtuosomodel.cpp <http://git.reviewboard.kde.org/r/106520/#comment15499> error? - Sebastian Trueg On Sept. 21, 2012, 9:27 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106520/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2012, 9:27 a.m.) > > > Review request for Nepomuk, Soprano and Sebastian Trueg. > > > Description > ------- > > Virtuoso doesn't support empty graphs, so we use a fake graph which acts > as the default empty graph. > > This approach, while useful, does have a performance impact, as the > graph needs to be regularly checked agains't this default graph. > > Therefore, we add an option to disable this feature. By default, this > feature is enabled in order to preserve compatibility. > > > Diffs > ----- > > backends/virtuoso/virtuosobackend.cpp ca5070f > backends/virtuoso/virtuosomodel.h b5fa1f8 > backends/virtuoso/virtuosomodel.cpp 2bc6fe2 > backends/virtuoso/virtuosomodel_p.h af58d12 > backends/virtuoso/virtuosoqueryresultiteratorbackend.cpp 914a320 > > Diff: http://git.reviewboard.kde.org/r/106520/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
