> On Sept. 27, 2012, 12:08 p.m., David Faure wrote: > > server/serverdatastream.cpp, line 52 > > <http://git.reviewboard.kde.org/r/106568/diff/1/?file=87131#file87131line52> > > > > I think this line is wrong and should be removed. > > See my fix 418ee0f194564e8734d0f06656316bbbd9623685 > > > > (and the cleanup of the commented out code in > > 439ae852647ca56f961eefcad6354c7c319eaeb0) > > > > both in soprano.git > > Vishesh Handa wrote: > Noted. I rather not do it in this patch, as I'm just splitting the code > up. > > I'll try to fix this up after I've committed this. > > @Sebastian: Ping? > > David Faure wrote: > Well it seems to me that the code was duplicated, and you picked the > wrong version of it, the one without my fix ;) > But if you're sure this is the only difference and you'll fix it up > afterwards, go ahead.
I'm a little confused. I just checked, and your commits affect client/socketstream.cpp not server/serverdatastream.cpp. So, I didn't really miss it. I'll remove the m_device->waitForReadyRead from the server code as well, but that will be in another commit so that it can go into 2.8 as well. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106568/#review19494 ----------------------------------------------------------- On Sept. 25, 2012, 2:56 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106568/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2012, 2:56 p.m.) > > > Review request for Nepomuk, Soprano and Sebastian Trueg. > > > Description > ------- > > Combine Server and Client streams into a new DataStream class > > Instead of both the server and the client implementing their own > streaming operators. We combine all the streaming operators into a new > public class called Soprano::DataStream. > > The Server and Client create their own respective class - > ServerDataStream and SocketStream respectively. The just have to > implement a read and write function. > > This serves to eliminate code duplication, and allows others to use the > DataStream class, if they need it. > > > Diffs > ----- > > client/CMakeLists.txt 4e73e3c > client/socketstream.h a7b1eb2 > client/socketstream.cpp 36472f1 > server/CMakeLists.txt 8155648 > server/datastream.h 0ecf2d3 > server/datastream.cpp f98ee2d > server/serverconnection.cpp 786f9df > server/serverdatastream.h PRE-CREATION > server/serverdatastream.cpp PRE-CREATION > soprano/CMakeLists.txt 28c3188 > soprano/datastream.h PRE-CREATION > soprano/datastream.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/106568/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
