----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106740/#review20077 -----------------------------------------------------------
services/storage/classandpropertytree.cpp <http://git.reviewboard.kde.org/r/106740/#comment15905> no need to have this twice. services/storage/classandpropertytree.cpp <http://git.reviewboard.kde.org/r/106740/#comment15906> see above. services/storage/classandpropertytree.cpp <http://git.reviewboard.kde.org/r/106740/#comment15907> you could keep the layout here: first check if its rdfs:Literal, then range.isEmpty. Then the patch would be that much simpler to review. ;) - Sebastian Trueg On Oct. 5, 2012, 3:56 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106740/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2012, 3:56 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > The extra url comparsions take approximately 50% of the time spent in > executing variantListToNodeSet. These comparisons are for special cases > and are done based on the property. > > They can be done when the tree is being created, instead of each time > this highly important function is called. > > * Caching the literal type - QVariant::Type > * Special handling for xsd:duration > * Special handling for rdfs:Literal > > > Diffs > ----- > > services/storage/classandpropertytree.h 3e3174d > services/storage/classandpropertytree.cpp 1a337b4 > > Diff: http://git.reviewboard.kde.org/r/106740/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
