----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106835/#review20648 -----------------------------------------------------------
Ship it! Ship It! - Vishesh Handa On Oct. 13, 2012, 7:31 p.m., Till Adam wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106835/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2012, 7:31 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > If one calls ResourceManager::instance()->initialized() in a new process, > where instance() is newly created, with the service already properly running, > the result is currently false. This is because while the ctor connects to the > services initialized signal and reacts to it, it does not call init() if the > service is already up. This patch attempts to rectify this by checking via > dbus if the service is up in the ctor and if so, initializing proactively. > > > Diffs > ----- > > libnepomukcore/resource/resourcemanager.cpp 2f01e47 > > Diff: http://git.reviewboard.kde.org/r/106835/diff/ > > > Testing > ------- > > Verify the initialized() method properly returns true in kdepim's contact > completion code, which has a fall back for the "nepomuk not running" case > which is often hit, atm, due to this issue. > > > Thanks, > > Till Adam > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
