----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107290/#review21807 -----------------------------------------------------------
Ship it! When you push the nepomuk patches, you have the green light for this. Thanks! - Ivan Čukić On Nov. 11, 2012, 4:25 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107290/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2012, 4:25 a.m.) > > > Review request for Nepomuk and Ivan Čukić. > > > Description > ------- > > Kactivities was checking whether nepomuk was available by watching for > ownership of its dbus service. However, the dbus service may appear > before the resourcemanager (which is what we want) is actually ready. > > Instead use the signals from libnepomukcore to tell when nepomuk > is turned on or off, thus avoiding talking to nepomuk before it is ready > to reply. > > This was part of triggering bug 295933. Fixing the bug fully also needs > #107285 and #107283 > > > This addresses bug 295933. > http://bugs.kde.org/show_bug.cgi?id=295933 > > > Diffs > ----- > > src/service/NepomukActivityManager.h bc2f9e3 > src/service/NepomukActivityManager.cpp e283e9f > > Diff: http://git.reviewboard.kde.org/r/107290/diff/ > > > Testing > ------- > > With the other two patches, the bug is fixed. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
