> On Nov. 12, 2012, 11:56 a.m., Vishesh Handa wrote: > > I've been trying to figure out a way to do this in Soprano. I haven't > > managed. > > > > This, however, is awesome!
Thanks! - Simeon ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107283/#review21870 ----------------------------------------------------------- On Nov. 11, 2012, 4:25 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107283/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2012, 4:25 a.m.) > > > Review request for Nepomuk, Vishesh Handa and Sebastian Trueg. > > > Description > ------- > > Manually disconnect the socket connection to nepomuk in the resourcemanager > when > nepomuk is shut down. > > This is needed because the Soprano method isConnected() does not > actually check whether the socket is connected or not, > merely whether it has been connected at some point in the past. > So if we do not disconnect, Nepomuk::MainModel::isValid() will falsely claim > that the connection is ready for data, causing problems > should anything try to use it. > > #107285 is the same commit for kdelibs nepomuk instead of nepomuk-core > nepomuk. > > > This addresses bug 295933. > http://bugs.kde.org/show_bug.cgi?id=295933 > > > Diffs > ----- > > libnepomukcore/resource/nepomukmainmodel.h 0d564b3 > libnepomukcore/resource/nepomukmainmodel.cpp d5cabed > libnepomukcore/resource/resourcemanager.cpp 66d9fcc > > Diff: http://git.reviewboard.kde.org/r/107283/diff/ > > > Testing > ------- > > Compiled, ran, checked that (with the corresponding commit to kdelibs, and a > kactivities fix) > it did actually fix bug 295933. > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
