----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107531/#review22926 -----------------------------------------------------------
Ship it! This is an amazingly good idea. The simpler this bit of code is, the more chance we have to debug some of the crazy crashes we're getting! - Simeon Bird On Nov. 30, 2012, 1:23 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107531/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2012, 1:23 p.m.) > > > Review request for Nepomuk, Soprano and Sebastian Trueg. > > > Description > ------- > > LocalSocketClient: Never delete the ClientConnection > > The ClientConnection is not reference counted, and is passed to the the > model and open iterators. Deleting it when has open iterators therefore > leads to crashes. > > Instead, the ClientConnection is always persistent. Intead we provide > functions to allow users of the ClientConnection to connect and > disconnect. > > Also removed the concept of newConnection() from the ClientConnection. > It no longer spawns a new socket for each thread, so there is no point > of it existing. This new design is a lot simpler. > > > Diffs > ----- > > client/clientconnection.h bfb3d4d > client/clientconnection.cpp febd008 > client/localsocketclient.cpp f3579ff > > Diff: http://git.reviewboard.kde.org/r/107531/diff/ > > > Testing > ------- > > Yup. Everything works fine. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
