----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107607/#review23174 -----------------------------------------------------------
Ship it! Makes sense, seems good to me. client/socketstream.cpp <http://git.reviewboard.kde.org/r/107607/#comment17726> Why was the socket access limited to 1024 bytes before? - Simeon Bird On Dec. 6, 2012, 9:36 a.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107607/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2012, 9:36 a.m.) > > > Review request for Nepomuk, Soprano, Sebastian Trueg, and Simeon Bird. > > > Description > ------- > > Client Local Socket: Check for EINTR error in socket calls > > Sometimes the calls to select, read, and write return with an EINTR > (Interrupted System call) error. The documentation says that in that > case, one should just try again. > > This solves some of the mysterious bugs of the socket timing out, and > then returning errors. I could reproduce this issue by running a large > number of queries in parallel by the nepomuk file indexer. > > Also, cleaned up the SocketStream code a little bit. It no longer needs > those extra checks in its read and write functions. > > > Diffs > ----- > > client/socket.cpp 28ac163 > client/socketstream.cpp 4db8be3 > > Diff: http://git.reviewboard.kde.org/r/107607/diff/ > > > Testing > ------- > > No more "Socket timed out error", and other problems. The errors were > completely reproducible. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
