> On Dec. 9, 2012, 3:55 a.m., Vishesh Handa wrote:
> > I'm trying to understand when would a case occur that m_client = 0.
> > m_client can never change once it has been set in the Model constructor, so
> > it should always have some value, unless it was explicitly set a 0. In that
> > case this crash will still happen.
> >
> > I think 690e59e13a9ba783f523f6129021fd4d5811642d fixes the issue, where the
> > client connection is never deleted.
> >
> > Both ways, this should go in.
> >
> > If you want you can push this into the 2.8 branch and then merge 2.8 into
> > master. Soprano releases are done when requested. I think we will need a
> > new one for KDE RC1. I'll have to ask Sebastian to release a new version.
I just read what I wrote - I meant that this patch only fixes the case when
m_client has been set to 0 on initialization. Practically though, in the
soprano code base, that never happens. m_client will always have some value -
StorageModel* model = new ClientModel( 0, modelId, &d->connection );
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107639/#review23176
-----------------------------------------------------------
On Dec. 9, 2012, 3:44 a.m., Simeon Bird wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107639/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2012, 3:44 a.m.)
>
>
> Review request for Nepomuk, Soprano, Vishesh Handa, and Sebastian Trueg.
>
>
> Description
> -------
>
> Fix crash on deletion if nepomuk has been disabled, as per bug 311222.
>
> (Should I submit this to master, or 2.8 branch as well? Where is the next
> soprano release coming from?)
>
>
> This addresses bug 311222.
> http://bugs.kde.org/show_bug.cgi?id=311222
>
>
> Diffs
> -----
>
> client/clientmodel.cpp bdcbed3
>
> Diff: http://git.reviewboard.kde.org/r/107639/diff/
>
>
> Testing
> -------
>
> Yup, it fixes the bug.
>
>
> Thanks,
>
> Simeon Bird
>
>
_______________________________________________
Nepomuk mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/nepomuk
