----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107533/#review23254 -----------------------------------------------------------
This review has been submitted with commit 10b7f75003ba77fac9c01c7b1aaaf03a03430e7d by Vishesh Handa to branch master. - Commit Hook On Nov. 30, 2012, 1:54 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107533/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2012, 1:54 p.m.) > > > Review request for Nepomuk and Sebastian Trueg. > > > Description > ------- > > NepomukMainModel: Never reset the localSocketModel > > We now never create a new LocalSocketModel on reconnecting. Instead we > continue using the old one. This way we do not leak memory, as we could > not delete the old model (open iterators). > > This is only possibly cause of the recent changes in Soprano which never > delete the inner ClientConnection which is shared between the model and > the LocalSocketClient. Before that commit the ClientConnection was > deleted which would result in the old model becoming invalid. > > This depends on https://git.reviewboard.kde.org/r/107531/ > > > Diffs > ----- > > libnepomukcore/resource/nepomukmainmodel.cpp 76bd6a3 > > Diff: http://git.reviewboard.kde.org/r/107533/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
