-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107760/
-----------------------------------------------------------

Review request for Nepomuk and Vishesh Handa.


Description
-------

I'm trying to figure out the nepomuk index problem for 4.10. Since after I 
upgrade.. it works quite differently. Since two level index is introduced.

After read through the code, I found that simple queue would have no/less 
problem, but file indexing queue case is much more different.
Seems there is no way to notify file indexing queue that some new data is 
needed to be indexed. So nepomuk cold start will not index any file content, 
since initially queue is empty.

My proposal is like this:
When PC enter the idle state, FileIndexing->resume will be called, currently, 
it will check the queue empty or not, so if it's empty, it will never be 
re-filled, which is quite bad.

So now we can always let pc using idle to recheck the state. Which is not very 
perfect, but it's practical.


Diffs
-----

  services/fileindexer/fileindexingqueue.h 11b577a 
  services/fileindexer/fileindexingqueue.cpp 1bda660 
  services/fileindexer/indexingqueue.h d51559f 
  services/fileindexer/indexingqueue.cpp ff48fa2 
  services/fileindexer/indexscheduler.cpp 0c56329 

Diff: http://git.reviewboard.kde.org/r/107760/diff/


Testing
-------

Compiles, work as it suppose to be.


Thanks,

Xuetian Weng

_______________________________________________
Nepomuk mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/nepomuk

Reply via email to