> On Jan. 5, 2013, 2:35 p.m., Luis Silva wrote: > > No problems that I cans see. Tested the patch and it seems to work. > > It's a "Ship It!" from me just don't know which branch it should go to. > > Jekyll Wu wrote: > Now that we are already in RC2 for 4.10, I this this should only go into > the master branch. Also the porting will introduce dependency change, > another bad thing for release. > > @Aurélien, do you think this porting deserves asking for exception from > release team ? (Hint: No :) ) > > >
Nepomuk2 is better than Nepomuk in almost every way. However, I don't think this is 'exception worthy'. The old "Nepomuk" API works fine, and there are no major bugs that require Gwenview to be ported in time for 4.10. - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108190/#review24740 ----------------------------------------------------------- On Jan. 5, 2013, 11:27 a.m., Jekyll Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108190/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2013, 11:27 a.m.) > > > Review request for Gwenview, Nepomuk and Vishesh Handa. > > > Description > ------- > > The change is mostly done by the porting script in > http://techbase.kde.org/Projects/Nepomuk/Nepomuk2Port . I just make 2 minimum > change manually to make it build and (seemingly) work. > > * Remove "#include <nepomuk2/global.h>", since that header is no longer > available in nepomuk-core > * Change "find_package(Nepomuk)" to "find_package(NepomukCore)" and related > parts > > > PS: I'm not familiar with the code of neither gwenview nor nepomuk. I come up > with this porting patch because gwenview crashes/hangs for me due to > kdelibs/nepomuk from time to time ... > > > Diffs > ----- > > CMakeLists.txt ce64825 > app/CMakeLists.txt 6627427 > app/filtercontroller.cpp c86ed9f > app/mainwindow.cpp 57f33a1 > app/startmainpage.cpp 1141c9e > lib/CMakeLists.txt d3f795f > lib/semanticinfo/nepomuksemanticinfobackend.cpp 606214c > tests/auto/CMakeLists.txt 6613f4e > tests/auto/semanticinfobackendtest.cpp 2f670e5 > > Diff: http://git.reviewboard.kde.org/r/108190/diff/ > > > Testing > ------- > > > Thanks, > > Jekyll Wu > >
_______________________________________________ Nepomuk mailing list Nepomuk@kde.org https://mail.kde.org/mailman/listinfo/nepomuk
