----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108580/#review26175 -----------------------------------------------------------
The earlier approach was to sort all the keys and then display then. It just happens that *most*, not all, of the time it was at the bottom since the editable keys started with k (kfileitem#rating, kfileitem#tags, etc). I like this approach better cause the editable data like the tagging widget is always in the same place. Since the TagWidget is something I expect the users to use a lot it would be nice if its position didn't change. It also makes for better muscle memory this way. @Frank: What do you think? - Vishesh Handa On Jan. 25, 2013, 3:39 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108580/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2013, 3:39 p.m.) > > > Review request for Dolphin, Nepomuk, Frank Reininghaus, and Vishesh Handa. > > > Description > ------- > > Provide Editable data at the bottom of the FileMetadataWidget, makes more > sense, and that is the same behavior as with the old one. > > > Diffs > ----- > > ui/filemetadataprovider.cpp 6f2a235 > > Diff: http://git.reviewboard.kde.org/r/108580/diff/ > > > Testing > ------- > > Compiled nepomuk-widgets with the patch, tags/ratings/comments are correctly > shown after e.g. album artist/track, etc. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Nepomuk mailing list Nepomuk@kde.org https://mail.kde.org/mailman/listinfo/nepomuk
