> On Feb. 5, 2013, 1:33 p.m., Vishesh Handa wrote: > > Do you think it would be better if we clubbed the CleaningJob in the > > nepomukcore library? Or should we really have this other cleaning library?
I think it should be separate since in an ideal world this tool would never be required. it is more of a high-level hack. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108773/#review26692 ----------------------------------------------------------- On Feb. 4, 2013, 3:46 p.m., Sebastian Trueg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108773/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2013, 3:46 p.m.) > > > Review request for Nepomuk. > > > Description > ------- > > This patch adds a simple plugin-system to the NepomukCleaner allowing other > applications to install Nepomuk2::CleaningJobs whcih are run in addition to > the default jobs. > > > Diffs > ----- > > cleaner/CMakeLists.txt af7f94b > cleaner/cleaningjob.h PRE-CREATION > cleaner/cleaningjob.cpp PRE-CREATION > cleaner/cleaningjobs.h e17bdfe > cleaner/cleaningjobs.cpp 05addda > cleaner/jobmodel.h a7b0618 > cleaner/jobmodel.cpp 8aadc83 > cleaner/nepomukcleaningjob.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/108773/diff/ > > > Testing > ------- > > Implemented two CleaningJobs for TV shows - works fine. > > > Thanks, > > Sebastian Trueg > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
