----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109044/#review27740 -----------------------------------------------------------
services/fileindexer/indexer/taglibextractor.cpp <http://git.reviewboard.kde.org/r/109044/#comment20795> This is...a bit crazy. Is reading a replaygain tag really that crazy? Why can't you use the taglib api http://taglib.github.com/api/classTagLib_1_1ID3v2_1_1RelativeVolumeFrame.html ? services/fileindexer/indexer/taglibextractor.cpp <http://git.reviewboard.kde.org/r/109044/#comment20792> You have three functions here which are the same except for type. Why don't you use a template? services/fileindexer/indexer/taglibextractor.cpp <http://git.reviewboard.kde.org/r/109044/#comment20794> Is there not a better way to get the filetype than this long wobbly if statement? Can't you do something like replayreader<Taglib::File::type()>(); replayreader.gettag(); ? services/fileindexer/indexer/taglibextractor.cpp <http://git.reviewboard.kde.org/r/109044/#comment20793> I added this check to avoid breaking indexing for certain crazy files I have...the date is set to 2^32-1, which overflows. Please could you leave it there? - Simeon Bird On Feb. 19, 2013, 5:10 p.m., Phalgun Guduthur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109044/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2013, 5:10 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > Add support for the indexer to extract replay gain data. > The code is heavily borrowed from the Amarok implementation of Taglib replay > gain. > > > Diffs > ----- > > services/fileindexer/indexer/taglibextractor.h 45baafc > services/fileindexer/indexer/taglibextractor.cpp a5a5ed6 > > Diff: http://git.reviewboard.kde.org/r/109044/diff/ > > > Testing > ------- > > Minimal. Code doesn't break. > > > Thanks, > > Phalgun Guduthur > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
