----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109398/#review29376 -----------------------------------------------------------
Ship it! Nice work! - Vishesh Handa On March 12, 2013, 5:41 p.m., Ignacio Serantes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109398/ > ----------------------------------------------------------- > > (Updated March 12, 2013, 5:41 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > Some frames could be duplicated in ID3v2 and Ogg specification so I added > support to duplicate artist and genre frames in MP3, Ogg and FLAC audio files. > > As I'm not a C/C++ this code could be a totally mess and for sure could be > optimized :). > > > Diffs > ----- > > services/fileindexer/indexer/taglibextractor.cpp a5a5ed6 > > Diff: http://git.reviewboard.kde.org/r/109398/diff/ > > > Testing > ------- > > Tested with my music database and seems to work properly. > > > Thanks, > > Ignacio Serantes > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
