----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109856/ -----------------------------------------------------------
(Updated April 5, 2013, 12:04 a.m.) Review request for Nepomuk and Vishesh Handa. Changes ------- ExtractorPlugin::dateTimeFromString used to convert datetime values. Description ------- There was a FIXME in exiv2extractor.cpp about datetime exif tag and I wrote the code required to convert information to exif format to xsd:datetime. I'm using val.setUtcOffset(0) to convert datetime generated by QDateTime::fromString() because datetime information stored in exif is in local time. If there is a better method to do this please inform me. This fix don't fix exactly the bug https://bugs.kde.org/show_bug.cgi?id=317501 because the bug is related to datetimes collected with strigi, but will permit to reindex images and solve the issue. In brief I'm not sure if I must assign this review to the bug or not. Diffs (updated) ----- services/fileindexer/indexer/exiv2extractor.cpp 7c7fe21 services/fileindexer/indexer/extractorplugin.cpp 5d834c9 Diff: http://git.reviewboard.kde.org/r/109856/diff/ Testing ------- With several photos in JPEG and NEF format comparing values obtained by extractor with values obtained by Digikam and exiv2 console program. Thanks, Ignacio Serantes
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
