----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110301/ -----------------------------------------------------------
(Updated May 4, 2013, 7:11 p.m.) Review request for Nepomuk and Vishesh Handa. Changes ------- Make watchFolder not accessible. Description ------- Filewatch: move all filewatching into the filewatch service Remove watch adding in the fileindexer service. On a config change they were previously being re-added twice. Then watch all indexed folders in filewatch constructor. This is needed so that nepomukctl restart filewatch watches all indexed folders. Don't bother to wait two minutes before installing the watches - it isn't that slow anymore and we were doing most of the work anyway by watching the homedir on startup. Diffs (updated) ----- interfaces/org.kde.nepomuk.FileWatch.xml 0befe7c476140d257e183f91a5e0cfed142b7eef services/fileindexer/fileindexer.h 1171b1190768f89491c66b6c4540f6631ef3b4cc services/fileindexer/fileindexer.cpp bd7ab6b83ced4cd02a4ffd20e85f64e52ac9acfd services/filewatch/nepomukfilewatch.h 52057df5ab3c8174c07c5542251c8c4f6bc65fdc services/filewatch/nepomukfilewatch.cpp c3e72931a218e9afc757cc3bcf51e14fc9e3689d Diff: http://git.reviewboard.kde.org/r/110301/diff/ Testing ------- Compiled, ran, checked it responds to config changes correctly. Thanks, Simeon Bird
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
