----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110354/#review32242 -----------------------------------------------------------
Ship it! I would like to keep that commit so please ship this. I have a couple of more changes that need to go into SDO before releasing a new version. - Vishesh Handa On May 8, 2013, 12:35 a.m., Andreas Hartmetz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110354/ > ----------------------------------------------------------- > > (Updated May 8, 2013, 12:35 a.m.) > > > Review request for Nepomuk, Ignacio Serantes and Vishesh Handa. > > > Description > ------- > > Actually I think that commit 79354558e6651946467656a4f0812f0e19381b51 should > be reverted because relying on unreleased SDO versions always causes pain and > suffering. Distro packages used to be sufficient for years, so people aren't > used to SDO master being required anymore. If 7935... is going to be kept, I > suggest that the patch posted here is merged. > > Planned commit message: > > Require shared-desktop-ontologies 0.10.51. > > This should have been in 79354558e6651946467656a4f0812f0e19381b51. > Without explicitly requiring the version, the build will fail with the > not too helpful error message that NMM::albumArtist is missing. > > > Diffs > ----- > > CMakeLists.txt 26facb7 > > Diff: http://git.reviewboard.kde.org/r/110354/diff/ > > > Testing > ------- > > The build fails as it should with distro SDO (0.10.0) and works with SDO > master (0.10.51). > > > Thanks, > > Andreas Hartmetz > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
