----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110767/#review33641 -----------------------------------------------------------
Ship it! Nice! Could you also add these ape files to Nepomuk2::SimpleIndexingJob::typesForMimeType(QString)? (nepomuk-core/services/fileindexer/indexer/simpleindexingjob.cpp). That way ape files will be counted as Audio files and shown after the first phase indexing as well. Also, could you please commit this to master and not 4.10. The KDE/4.10 branch is in a messed up state. I rather not touch it. - Vishesh Handa On June 1, 2013, 2:40 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110767/ > ----------------------------------------------------------- > > (Updated June 1, 2013, 2:40 p.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > Some people have them, so why not index them ;-) > > > Diffs > ----- > > services/fileindexer/indexer/taglibextractor.cpp 941cf74 > > Diff: http://git.reviewboard.kde.org/r/110767/diff/ > > > Testing > ------- > > nepomukshow Facedancers.ape > <nepomuk:/res/eb857393-5cae-4a14-8d50-5b455934c538> > rdf:type nmm:MusicPiece > > rdf:type nfo:Audio > > rdf:type nfo:FileDataObject > > rdf:type nie:InformationElement > > nao:created 2013-06-01T14:32:21.091Z > > nao:lastModified 2013-06-01T14:32:21.614Z > > nie:url file:///home/hrvoje/Facedancers.ape > > nie:mimeType audio/x-ape > > nie:title Facedancers > > nie:lastModified 2013-06-01T14:31:19Z > > nie:created 2013-06-01T14:31:19Z > > nfo:averageBitrate 6.7700000000e+05 > > nfo:sampleRate 4.4100000000e+04 > > nfo:fileSize 204670665 > > nfo:fileName Facedancers.ape > > nfo:channels 2 > > nfo:duration 2416 > > nmm:performer nepomuk:/res/08d5211e-85ae-472e-b29b-9b3038a08288 > > nmm:musicAlbum nepomuk:/res/e9dde4e6-ae72-4ede-8d9d-c38106ea1470 > > nmm:releaseDate 1972-01-01T00:00:00Z > > kext:indexingLevel 2 > Somehow nepomukshow didn't catch performer and album, but it's visible in the > widget/tooltip > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
