----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110877/#review34037 -----------------------------------------------------------
Ship it! Ship It! - Vishesh Handa On June 8, 2013, 3:21 a.m., Simeon Bird wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110877/ > ----------------------------------------------------------- > > (Updated June 8, 2013, 3:21 a.m.) > > > Review request for Nepomuk and Vishesh Handa. > > > Description > ------- > > Resource: Null guards for m_data > > It is possible, during shutdown, for m_data to be null briefly (see > ResourceManager::cleanupResources). If a property were accessed > during this time, we could crash. > > The patch checks whether m_data is null in various functions, and > returns empty items if so. > > BUG: 320097 > BUG: 319481 > > > This addresses bugs 319481 and 320097. > http://bugs.kde.org/show_bug.cgi?id=319481 > http://bugs.kde.org/show_bug.cgi?id=320097 > > > Diffs > ----- > > libnepomukcore/resource/resource.cpp > da352e1d3ab2bd3d61ec6c2d85e59ffde09914d1 > > Diff: http://git.reviewboard.kde.org/r/110877/diff/ > > > Testing > ------- > > Compiled, ran > > > Thanks, > > Simeon Bird > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
