> On Aug. 8, 2013, 9:06 p.m., Albert Astals Cid wrote: > > I can confirm that the new test fails without the patch and works with it. > > I can't assess the correctness of the code itself since my nepomuk-foo ? 0 > > > > It'd be cool if someone else from nepomuk-land can try to review. If not > > I'll guess we'll have to trust Vishesh and commit it :-)
I can vouch that the patch looks sensible and will do what Vishesh says. Ship it from me. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111949/#review37385 ----------------------------------------------------------- On Aug. 8, 2013, 7:04 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111949/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 7:04 p.m.) > > > Review request for Nepomuk and Release Team. > > > Description > ------- > > Only files with tags used to be backed up. If a file had only a rating > or a comment then its information would not be backed up. > > > Diffs > ----- > > autotests/test/backuptests.cpp 7284dd6 > services/storage/backup/resourcelistgenerator.cpp 059bfa7 > > Diff: http://git.reviewboard.kde.org/r/111949/diff/ > > > Testing > ------- > > Tested by manually backing up a number of times. > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
