----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113128/#review41338 -----------------------------------------------------------
Ship it! If you're having problems with the telepathy service crashing, then I can port it to Nepomuk::Service2 whose architecture is a lot better. Plus you get your own process name. Should I do it? - Vishesh Handa On Oct. 6, 2013, 10:49 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113128/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2013, 10:49 a.m.) > > > Review request for Nepomuk. > > > Repository: nepomuk-core > > > Description > ------- > > Don't delete a QObject from inside a slot. > > If there are any pending calls to that object to be processed deleting > the object can cause them to crash. (such as in KTp's service) > > Using deleteLater() is safer. > > BUG: 325376 > > > Diffs > ----- > > servicestub/servicecontrol.cpp efc8eb8 > > Diff: http://git.reviewboard.kde.org/r/113128/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Nepomuk mailing list [email protected] https://mail.kde.org/mailman/listinfo/nepomuk
