On 12/10/2012 09:06 PM, Dmitry Samersoff wrote:
Chris,
Looks good for me.
Thank you Dmitry,
PS:
Inet6Address.java:
It's not necessary to remove explicit initializations - compiler do it
perfectly for you.
This is a pet peeve of mine. I don't like to see them in code. javac
generates extra bytecodes to initialize these fields, and in most cases
it is completely unnecessary. Just take a look at the output of a simple
test.
-Chris.
-Dmitry
On 2012-12-10 20:01, Chris Hegarty wrote:
Inet6Address.getHostAddress() is specified to return the IP address
string in textual presentation, followed by a '%' character and the
scope identifier. This scope identifier can be either a numeric value or
a string, depending on how the instance was created (if it was created
with a scoped interface).
This change proposes to remove the boolean field, 'scope_ifname_set',
since it is not always correctly set when the instance contains a valid
scoped interface. For example, when iterating over the
NetworkInterface's on the system. 'scope_ifname_set' was never accessed
from native code, so it can simply be removed.
http://cr.openjdk.java.net/~chegar/8004675/webrev.00/webrev/
-Chris.
