Looks good to me Mark. I can sponsor this for you.
-Chris. On 09/05/2013 05:07 PM, Mark Sheppard wrote:
Hi, please oblige and review the latest version of the fix below to address the issue in JDK-8021372: NetworkInterface.getNetworkInterfaces() returns duplicate hardware address This incorporates Chris' suggestions wrt amending the associated test. http://cr.openjdk.java.net/~msheppar/8021372/webrev.02/ regards Mark On 04/09/2013 11:39, Chris Hegarty wrote:Mark, The source changes look good to me. The test is a good addition, but trivially I would... 1) remove the @build and @run tags. I don't think they are needed as I don't see that the test needs to run in othervm mode. 2) remove all exception handling code, and just declare all methods to throw Exception. The jtreg harness will show the test as failed if an unhandled exception is thrown. -Chris. On 04/09/2013 08:59, Mark Sheppard wrote:Hi based on feedback for initial fix, an amended webrev has been created. So, please oblige and review the fix below to address the issue in JDK-8021372: NetworkInterface.getNetworkInterfaces() returns duplicate hardware address webrev: http://cr.openjdk.java.net/~msheppar/8021372/webrev.01/ regressions re-run with no ill effects regards Mark
