I'm sure Michael will look at this but I have a question - shouldn't SocketImpl throw UOE for this case? I'm just wondering if checking the supported options in setOption/getOption is just covering up an issue with the SocketImpl methods.

-Alan


On 08/12/2015 12:36, Svetlana Nikandrova wrote:
Little reminder.

On 03.12.2015 16:06, Svetlana Nikandrova wrote:
Hello,

please review a simple fix for:
https://bugs.openjdk.java.net/browse/JDK-8143554

See webrev here:
http://cr.openjdk.java.net/~kshefov/8143554/webrev.00/ <http://cr.openjdk.java.net/%7Ekshefov/8143554/webrev.00/>

Fix added explicit check for option support to getOption and setOption sockets' methods similar way as it was done prior jdk 9 in Sockets class. Fix also exposed another problem with sockets' supported options: JDK-8143923 <https://bugs.openjdk.java.net/browse/JDK-8143923> that cause new test failure test/java/net/SocketOption/OptionsTest.java. I added test to the ProblemList.

Thank you,
Svetlana


Reply via email to