This looks okay. I think it would be good to put a javadoc comment on
this method, also maybe move it to below all the constructors rather
than in the middle.
-Alan.
On 28/01/2016 16:38, Claes Redestad wrote:
On 2016-01-28 16:52, Chris Hegarty wrote:
...
This looks fine Claes.
Thanks, Chris!
Maybe just a comment on the fact that character based comparison is
being used for perf reasons.
In an older version of the webrev, there was an updated to an
existing test,
test/java/net/URI/URItoURLTest.java. I assume this was just mistakenly
omitted from the latest version?
Fixed test and added a comment:
http://cr.openjdk.java.net/~redestad/8147462/webrev.05/
Thanks!
/Claes
