Hi Chris,
thanks for review, please find the updated webrev. I updated the
existing test case to cover this issue.
http://cr.openjdk.java.net/~vtewari/8151586/webrev0.1/index.html
<http://cr.openjdk.java.net/%7Evtewari/8151586/webrev0.1/index.html>
Thanks,
Vyom
On Tuesday 15 March 2016 05:08 PM, Chris Hegarty wrote:
Vyom,
On 15/03/16 09:51, vyom wrote:
Hi,
Please review the below fix.
Bug: JDK-8151586 : Wrong exception catch for FTPClient in JDK-8055032
Webrev :http://cr.openjdk.java.net/~rgoel/~vyom/8151586/webrev0.0/
<http://cr.openjdk.java.net/%7Ergoel/%7Evyom/8151586/webrev0.0/>
The source change looks ok.
The test attempts to connect to an external ftp site. It
just fails on my machine with java.net.NoRouteToHostException.
Does the test need to run in othervm mode. I think not.
To simplify the test, just add 'throws IOException' to
main, so you don't have to deal with wrapping these in
RuntimeException. If a test fails with an IOException it
will be reported as failed by the test harness. Try it.
-Chris.
