On 26/04/2016 10:16, Chris Hegarty wrote:
On 26 Apr 2016, at 09:20, Alan Bateman <alan.bate...@oracle.com> wrote:
On 25/04/2016 22:01, Chris Hegarty wrote:
One of the remaining open issues in JEP 200 [1] is that the base module
exports the jdk.net package, thereby violating Principle 4 of JEP 200:
a Java SE module must not export any non-SE API packages without
qualification.
http://cr.openjdk.java.net/~chegar/8044773/
https://bugs.openjdk.java.net/browse/JDK-8044773
I took a first pass over this and it looks very good.
Thanks Alan.
Webrev updated in-place:
http://cr.openjdk.java.net/~chegar/8044773/jdk/
I took a second pass over it. One thing that I'm wondering about is
whether BaseExtendedSocketOptions + Support should be collapsed into one
abstract class ExtendedSocketOptions (or better name) with 3 instance
methods and 2 static methods. It's an internal interface so not a big
deal but I think it would be a bit cleaner and allowed the oddly named
"Support" to go away.
-Alan
