Christoph, > On 1 Jun 2016, at 08:33, e...@zusammenkunft.net wrote: > > Hello, > > Since nobody commented, here is my non binding comment: > > I am not sure which Exception call-site actually improved (i.e. added the > error code)? I would split out the improvement of this/those throws and the > refacturing of the code.
Yes, please. > Personally I would prefer to keep the NET_ variant and adjust the native > utilities to remove code duplication. Also I dislike the change from "java/net/SocketException” to JNU_JAVANETPKG “SocketException”. My preference is to keep the former / original. > Does your new version still contain the nummric error code (os error messages > are unfortunatelly translated). -Chris. > Gruss > Bernd > -- > http://bernd.eckenfels.net > > -----Original Message----- > From: "Langer, Christoph" <christoph.lan...@sap.com> > To: "net-dev@openjdk.java.net" <net-dev@openjdk.java.net> > Sent: Mi., 01 Juni 2016 9:20 > Subject: Ping - RFR 8158023: SocketExceptions contain too little information > sometimes > > Hi, > > ping - any comments on this? > > Thanks > Christoph > > From: Langer, Christoph > Sent: Freitag, 27. Mai 2016 10:30 > To: net-dev@openjdk.java.net > Cc: core-libs-...@openjdk.java.net; nio-...@openjdk.java.net > Subject: RFR 8158023: SocketExceptions contain too little information > sometimes > > Hi all, > > please review the following change: > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8158023.1/ > Bug: https://bugs.openjdk.java.net/browse/JDK-8158023 > > During error analysis I stumbled over a place where I encountered a > SocketException which was thrown along with some strerror information as > message. I found it hard to find the originating code spot with that > information. > > So I looked at the places where we throw exceptions, namely JNU_Throw... and > NET_Throw... functions and came up with the following enhancement: > - NET_ThrowByNameWithLastError can go completely as it does not provide any > benefit over JNU_ThrowByNameWithLastError. > - JNU_ThrowByNameWithLastError can be cleaned up. > > - I added JNU_ThrowByNameWithMessageAndLastError to print out a string like > message + ": " + last error. > > - I went over all places where NET_ThrowByNameWithLastError is used and > replaced it appropriately. > > Do you think this change is desirable/possible? > > Though it's mainly a net topic, I'm posting it to nio-dev and core-libs-dev > as well as JNU_Throw... code affects all. > > Best regards > Christoph >
