> On 16 Jun 2016, at 18:55, Roger Riggs <roger.ri...@oracle.com> wrote: > > Hi Vyom, > > Looks ok,
+1. I attempted to add a test for https, and just realised that the javax.net.SocketFactory does not support Socket(Proxy). It may be worth capturing this issue somewhere, but it is way beyond the scope of this bug, and less of an issue with the new HTTP Client alternative. -Chris. > Roger > > On 6/16/2016 10:35 AM, Vyom Tewari wrote: >> Hi All, >> >> Please find the latest >> webrev(http://cr.openjdk.java.net/~vtewari/8144008/webrev0.1/index.html >> <http://cr.openjdk.java.net/%7Evtewari/8144008/webrev0.1/index.html>), i got >> some off line comments from Chris. >> >> Thanks, >> Vyom >> >> On Tuesday 14 June 2016 12:11 PM, Vyom Tewari wrote: >>> Hi All, >>> >>> Please review the below fix. >>> Bug : JDK-8144008 Setting NO_PROXY on an URLConnection is not >>> complied with >>> Webrev : >>> http://cr.openjdk.java.net/~vtewari/8144008/webrev0.0/index.html >>> <http://cr.openjdk.java.net/%7Evtewari/8144008/webrev0.0/index.html> >>> >>> Thanks, >>> Vyom >>> >> >
