On 22/07/16 09:59, Daniel Fuchs wrote:
Hi Vyom,
It would be helpful in the future to include a link to the
JBS issue in your request for review.
464 //The colon separator need to be present even if the
request headers list is empty
I would suggest the comment to be a little more precise:
// The colon separator is optional when the request headers
// list is empty. This implementation chooses to include
// it even when the request headers list is empty.
Otherwise looks good!
+1.
For the other reviewers on this list the gist of the issue is
that a side effect of a recent fix [1] changed the behavior of
URLPermission to omit the colon separator when the request headers
list is empty (the spec allows this).
However some previously existing tests started failing [2] because
of that.
Because the spec allows the colon separator to be always
present, whether the request list is empty or not, we're
proposing to be conservative and continue to add the
colon separator in all cases.
[1] https://bugs.openjdk.java.net/browse/JDK-8114860
[2] https://bugs.openjdk.java.net/browse/JDK-8161291
Thanks for the explanation Daniel, it is really helpful to fully
understand the issue, and the proposed solution.
-Chris.
best regards,
-- daniel
On 22/07/16 06:04, Vyom Tewari wrote:
Hi,
Please review the below code change.
Bug : JDK-8161291 Serialization Tests for URLPermission is
failing
Webrev :
http://cr.openjdk.java.net/~vtewari/8161291/webrev0.0/index.html
<http://cr.openjdk.java.net/%7Evtewari/8161291/webrev0.0/index.html>
This change make sure that colon separator need to be present even if
the request headers list is empty.
Thanks,
Vyom
