On 27 Sep 2016, at 09:35, Felix Yang <felix.y...@oracle.com> wrote: > > Chris, > > I will push without othervm
Thanks. If we see future issues with this test, then we can add it back. -Chris. > -Felix > On 2016/9/27 16:29, Chris Hegarty wrote: >> On 27 Sep 2016, at 09:25, Felix Yang <felix.y...@oracle.com> wrote: >>> Hi Chris, >>> >>> updated as suggested >>> >>> http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.01/ >> Looks good to me. >> >> Up to you, but with the thread join ( if my hunch is correct ) we may not >> actually need othervm, but of course it should be fine with it too. >> >> -Chris. >> >>> Thanks, >>> Felix >>> On 2016/9/27 15:55, Chris Hegarty wrote: >>>>> On 27 Sep 2016, at 03:08, Felix Yang <felix.y...@oracle.com> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> please review following test fix. >>>>> >>>>> Bug: >>>>> >>>>> https://bugs.openjdk.java.net/browse/JDK-8154525 >>>>> >>>>> Webrev: >>>>> >>>>> http://cr.openjdk.java.net/~xiaofeya/8154525/webrev.00/ >>>>> >>>>> This test has been observed to fail sometimes with "Error while cleaning >>>>> up threads after test ", even after test complete message printed. >>>>> Updated it to run with othervm mode. >>>> I think this is fine. Additionally, should the main thread wait/join >>>> the “Server” thread before exiting, to ensure that it is complete >>>> before the test returns ( this would eliminate any potential race >>>> while cleaning up ). >>>> >>>> -Chris. >
