Hi Christoph, this change looks reasonable but I wonder if this requires one of these dubious CCC requests/approvals? Maybe one of the process experts can answer :)
Regards, Volker On Wed, Dec 7, 2016 at 9:38 AM, Langer, Christoph <christoph.lan...@sap.com> wrote: > Hi, > > > > please review this small fix. > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8164057 > > Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8164057.0/ > > > > The root cause of the wrong “@since” tags probably is that the classes > Inet[46]Address had been created as copy of InetAddress. InetAddress itself > obviously exists since 1.0 and methods have been added over time. The > copying of InetAddress towards Inet[46]Adress has been done for Java 1.4 and > hence all Javadoc that was tagged @since <1.4 is not correct for the new > classes. > > > > I suggest to remove all @since <= 1.4 since the classes themselves are > annotated “@since 1.4” which would imply all unannotated methods exist from > 1.4 onwards. Alternatively we could a) remove only occurences of @since < > 1.4 or b) change all @since < 1.4 to @since 1.4. > > > > Best regards > > Christoph > >
