Hi Chris, Looks good to me as well.
cheers, -- daniel On 20/02/17 16:14, Chris Hegarty wrote:
The fix for 8163449 [1] "Allow per protocol setting for URLConnection defaultUseCaches", does not work for JAR URLs ( which embed URLs to the actual artifact ). The problem is that sun.net.www.protocol.jar.JarURLConnection passes all of the [g|s]et[Default]UseCaches() method calls to the embedded jar file URLConnection. This means any attempt to control caching for just JAR URLs fails. "jar" always ends up being treated like whatever the embedded URL is, which is exactly the case that 8163449 was trying to address. JarURLConnection should set the initial cache value of its emdedded URLConnection ( to the actual resource ), to whatever its initial value is. Subsequent set/getUseCaches will then behave as expected. http://cr.openjdk.java.net/~chegar/8175261.00/ https://bugs.openjdk.java.net/browse/JDK-8175261 -Chris [1] https://bugs.openjdk.java.net/browse/JDK-8163449