Ping.
Please review the proposed change at your convenience.
The fix will greatly reduce the possibility of a need to reallocate the
buffer to retrieve the results (something that the documentation
strongly suggests to avoid), and, if such reallocation still occurs to
be necessary, will increase number of retries.
With kind regards,
Ivan
On 9/19/17 10:50 AM, Ivan Gerasimov wrote:
Hello!
When retrieving information about network interfaces on Windows we
make up to 2 attempts to call GetAdaptersAddresses().
It was reported that in very rare cases it may not be sufficient, and
even the second attempt can fail with ERROR_BUFFER_OVERFLOW.
I suggest that we follow the recommendation given in MSDN [1]:
increase the initial buffer size to 15K and do up to 3 attempts to
call GetAdaptersAddresses().
BUGURL: https://bugs.openjdk.java.net/browse/JDK-8187658
WEBREV: http://cr.openjdk.java.net/~igerasim/8187658/00/webrev/
Would you please help review the fix?
[1]
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365915(v=vs.85).aspx
--
With kind regards,
Ivan Gerasimov
