> On Oct 31, 2018, at 12:16 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 31/10/2018 19:13, Brian Burkhalter wrote: >> https://bugs.openjdk.java.net/browse/JDK-8213210 >> <https://bugs.openjdk.java.net/browse/JDK-8213210> >> >> Please see diff included below. CSR to follow. > One thing to check is whether ServerSocket specifies null handling anywhere. > I don't think it does so you might have to add an @throws NPE.
SocketImpl.serServerSocket() cannot throw NPE so I don’t see that the updated ctor can throw it either: void setServerSocket(ServerSocket soc) { this.serverSocket = soc; } - ServerSocket(SocketImpl impl) { + protected ServerSocket(SocketImpl impl) { this.impl = impl; impl.setServerSocket(this); } Brian