Hi Aleks, latest changes looks good to me . Thanks, Vyom On Wed, May 15, 2019 at 11:12 PM Aleks Efimov <aleksej.efi...@oracle.com> wrote:
> Hi Daniel, > > Thanks for the review. I've modified Socket_getInputStream_[read|write] > to follow your suggestion: > - ServerSocket ss = new ServerSocket(0); > InetAddress lh = InetAddress.getLocalHost(); > + ServerSocket ss = new ServerSocket(0, 0, lh); > > Also I've broke the long lines in few places. Will push the changes > shortly. > > With Best Regards, > Aleksei > > On 15/05/2019 17:59, Daniel Fuchs wrote: > > Hi Aleksei, > > > > On 15/05/2019 17:07, Aleks Efimov wrote: > >> Hi, > >> > >> Another part of test fixes to address intermittent networking test > >> failures can be viewed here: > >> http://cr.openjdk.java.net/~aefimov/8223798/00/ > > > > Socket_getInputStream_read.java: > > Socket_getOutputStream_write.java: > > > > I think you could simply move the initialization of > > lh above the line that creates the server socket > > and bind the server socket to lh instead. That > > would keep the changes minimal. > > > > The rest looks good - but there are a few long lines. > > If you can break them before pushing that would be good. > > > > best regards, > > > > -- daniel > > > >> > >> Could I please ask for the help to review it? > >> > >> JBS: > >> https://bugs.openjdk.java.net/browse/JDK-8223798 > >> > >> > >> With Best Regards, > >> Aleksei > > > > -- Thanks, Vyom
