Re: RFR [13] 8225426: Replace plain with system-default in Socket and ServerSocket

[Daniel Fuchs]

Hi Chris,

looks good to me. I just wonder if:

 "Otherwise a system-default implementation is created."

would read better - but I'll defer to your judgement.

I also noticed one typo:

On 07/06/2019 12:24, Chris Hegarty wrote:

[snip]

src/java.base/share/classes/java/net/ServerSocket.java

[snip]

there's a space missing before 'Otherwise' below:

-     * the actual socket implementation. Otherwise a "plain" socket is created.
+     * the actual socket implementation.Otherwise a system-default
+     * {@code SocketImpl} is created.
       * <p>
       * If there is a security manager, its
       * {@code checkConnect} method is called
       * with the host address and {@code port}
       * as its arguments. This could result in a SecurityException.
       * <p>
       * If a UDP socket is used, TCP/IP related socket options will not apply.
       *
       * ...
       */
      @Deprecated
      public Socket(String host, int port, boolean stream)

best regards,

-- daniel