Hi Julia,

(part 19 (!))

In AsyncDisconnect line 57 could be replaced with ioe.printStackTrace() to be 
consistent with lines 85 and 88.
Same thing for B6641309 line 58, and B6660405 line 108.

I’ll leave comments on the more substantive changes to the net-dev experts.

Thanks,

Brian

> On Jun 26, 2019, at 10:33 AM, Julia Boes <julia.b...@oracle.com> wrote:
> 
> webrev:
> 
> http://cr.openjdk.java.net/~dfuchs/jboes/webrev_8226825/webrev/ 
> <http://cr.openjdk.java.net/~dfuchs/jboes/webrev_8226825/webrev/>
> 
> - Replaced wildcard address with loopback or localhost in all tests
> 
> - Replaced URL constructor with URIBuilder
> 
> - Set proxy to null per default for all tests but SetSoLinger
> 
> - Test B6660405 now checks the length of the input stream and throws an 
> AssertionError if the length is not as expected.

Reply via email to