On Thu, 10 Sep 2020 08:51:33 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:

>> src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpExchange.java 
>> line 192:
>> 
>>> 190:      *        no response body may be written.
>>> 191:      * @throws IOException An IOException will be thrown if an error 
>>> occurs during
>>> 192:      *         the sending of response headers, or if headers have 
>>> already been sent.
>> 
>>> "or if headers have already been sent."
>> 
>> Maybe I missed it, but is there a test to assert this?  It is not obvious to 
>> me why this is being added now.
>
> +1 for adding a small test to verify that `IOException` is thrown if 
> `sendResponseHeaders()` is called twice (unless
> that test already exists). I assume Patrick figured that out by reading the 
> corresponding code?

Chris and I discussed this offline, and it was decided to separate this change 
out into a new issue and deal with it
there. See https://bugs.openjdk.java.net/browse/JDK-8253005.

-------------

PR: https://git.openjdk.java.net/jdk/pull/81

Reply via email to