On Wed, 3 Feb 2021 14:19:27 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> Julia Boes has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   small adjustment
>
> src/java.base/share/classes/java/net/InetSocketAddress.java line 387:
> 
>> 385:      * To retrieve a string representation of the hostname or the 
>> address, use
>> 386:      * {@link #getHostString()}, rather than parsing the string 
>> returned by this
>> 387:      * {@link #toString()} method.
> 
> A couple of small suggestions:
> - "This string" -> "The string"
> - For the IPv6 literal case it would good to make it clear that it is 
> enclosed in square brackets before append the colon and port. It might also 
> be better to not have this in a separate paragraph because it follows 
> immediately from the previous sentence.
> - The final sentence "To retrieve ..." might be better starting with "Use 
> getHostString to get the String representation ..."

Agreed offline to not apply these suggestions

-------------

PR: https://git.openjdk.java.net/jdk/pull/2357

Reply via email to