On Wed, 3 Feb 2021 11:35:07 GMT, Daniel Fuchs <[email protected]> wrote:
>> Patrick Concannon has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits since the last revision:
>>
>> - 8235139: Updated @deprecated text for setSocketFactory methods in Socket
>> and ServerSocket
>> - Merge remote-tracking branch 'origin/master' into JDK-8235139
>> - 8235139: Remove the socket impl factory mechanism
>
> src/java.base/share/classes/java/net/Socket.java line 546:
>
>> 544: @SuppressWarnings("deprecation")
>> 545: void setImpl() {
>> 546: SocketImplFactory factory = Socket.factory;
>
> The scope of `@SuppressWarnings` should be reduced as much as possible. I
> believe in this case it can be reduced to the assignation of the factory:
>
> @SuppressWarnings("deprecation")
> SocketImplFactory factory = Socket.factory;
`@SuppressWarnings` moved down to next line as suggested. See e36f91d
-------------
PR: https://git.openjdk.java.net/jdk/pull/2375
