On Wed, 17 Feb 2021 13:36:18 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Hi Jaikiran, >> >> Thanks for taking a go at this one. >> >> At a glance - the proposed fix seems reasonable to me. It would be good to >> have another pair of eyes (and analysis) on this though. Some issues with >> the test. > > Hello Daniel, thank you for the review. I have updated this PR to incorporate > your review suggestions for the test. Changes looks OK to me, any specific reason for removing "final" specifier from "getInstance" & "register" methods ?. ------------- PR: https://git.openjdk.java.net/jdk/pull/2601
