On Tue, 16 Mar 2021 15:01:02 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Jonathan Dowland has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Correct test invocation metadata >> >> -Xcheck:jni prior to the main class declaration; /othervm suffix now >> that we are specifying JVM options. I now see the local ref warnings >> in the jtreg output (JTwork, not JTreport). >> >> Thanks Chris Hegarty. >> - windows/NetworkInterface: move deletions next to last-use >> >> Similar to review comment for the unix code. Also ensure ia2Obj is >> only cleaned up if it was definitely allocated. Thanks Chris Hegarty. > > Thanks for making these changes. This is much easier to review now. I'm not > an expert with JNI ref - but the logic now looks right. Please hold off on this; there's an issue to clear up. ------------- PR: https://git.openjdk.java.net/jdk/pull/2963
