On Mon, 22 Mar 2021 22:16:09 GMT, Michael McMahon <[email protected]> wrote:
>> Hi,
>>
>> The fix for the reported bug in Utils.CONTEXT_RESTRICTED caused a couple of
>> regression failures, which turned out to be another bug exposed by this fix
>> where HTTP/1.1 CONNECT requests with authentication were filtering out proxy
>> authentication headers wrongly. This was because the HttpRequestImpl created
>> for the repeated CONNECT was putting the system headers in the user headers
>> area of the HttpRequestImpl. The fix for that is to supply the user and
>> system headers direct to the place where the new HttpRequestImpl is created.
>>
>> Thanks
>> Michael
>
> Michael McMahon has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Updated test to test proxy authorization
Marked as reviewed by dfuchs (Reviewer).
test/jdk/java/net/httpclient/AuthFilter.java line 145:
> 143: if (useProxy) {
> 144: proxy = new ProxyServer();
> 145: proxyAddr = new InetSocketAddress("127.0.0.1",
> proxy.getPort());
Maybe the test should be guarded in case the machine is IPv6 only
test/jdk/java/net/httpclient/AuthFilter.java line 160:
> 158: if (useProxy) {
> 159: builder.proxy(ProxySelector.of(proxyAddr));
> 160: }
You should probably set NO_PROXY otherwise to avoid the default proxy selector
on mac.
-------------
PR: https://git.openjdk.java.net/jdk/pull/2977
