On Wed, 28 Apr 2021 13:20:23 GMT, Julia Boes <[email protected]> wrote:
>> Add two static factory methods to com.sun.net.httpserver.Filter that
>> facilitate the creation of pre- and post-processing Filters:
>>
>> `public static Filter beforeResponse(String description,
>> Consumer<HttpExchange> filterImpl) {}`
>> `public static Filter afterResponse(String description,
>> Consumer<HttpExchange> filterImpl) {}`
>
> Julia Boes has updated the pull request incrementally with one additional
> commit since the last revision:
>
> some more spec updates and small test cleanup
I wonder if instead of simply saying:
* @return a filter
we should say:
* @return a filter whose operation is invoked before the exchange is handled
* @return a filter whose operation is invoked after the exchange is handled
Otherwise, LGTM!
No need for a new review if you take on these changes.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3468
