On Fri, 21 May 2021 15:35:05 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> typo on windows > > src/java.base/share/classes/sun/net/ftp/impl/FtpClient.java line 120: > >> 118: vals[1] = >> Integer.getInteger("sun.net.client.defaultConnectTimeout", >> 300_000).intValue(); >> 119: return System.getProperty("file.encoding", >> "ISO8859_1"); >> 120: } > > It is a bit strange that "file.encoding" seem to get a special treatment - > but I guess that's OK. You might say we thus avoid wasting the return value, as much as possible. ------------- PR: https://git.openjdk.java.net/jdk/pull/4138