On Fri, 28 May 2021 13:11:43 GMT, Chris Hegarty <che...@openjdk.org> wrote:
> The SCTP channel factory methods, namely SctpChannel::open, > SctpServerChannel::open, and SctpMultiChannel::open, are specified to throw > UnsupportedOperationException, if the SCTP protocol is not supported. > Currently, underlying platform support is assumed once the appropriate > libsctp.so.1 library is present (along with its supported interface > functions). This may not always be the case, e.g. if the Linux sctp kernel > module is not present or loaded. In which case a SocketException is thrown. > > It would be more appropriate to check for EPROTONOSUPPORT and > ESOCKTNOSUPPORT, and throw UOE rather than SE. > > The existing java/net/SctpSanity.java tests already covers this case, when > run on platforms without support. java/net/SctpSanity.java passed on our machine with this patch. Thanks for fixing it. ------------- Marked as reviewed by jiefu (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4246
