On Thu, 3 Jun 2021 10:12:03 GMT, Patrick Concannon <pconcan...@openjdk.org> wrote:
>> Hi, >> >> Could someone please review my code for updating the code in the `java.net` >> and `java.nio` packages to make use of the switch expressions? >> >> Kind regards, >> Patrick > > Patrick Concannon has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains eight additional > commits since the last revision: > > - 8268056: renamed variable in Files > - Merge remote-tracking branch 'origin/master' into JDK-8268056 > - Merge remote-tracking branch 'origin/master' into JDK-8268056 > - 8268056: Added yield to switch expression in Files > - 8268056: reverted changes to FileTime > - Merge remote-tracking branch 'origin/master' into JDK-8268056 > - 8268056: Reverted changes to URLDecoder; reformatted change to FileTime > - 8268056: Update java.net and java.nio to use switch expressions Updated patch looks okay. I'm not 100% sure that it's a significant improvement over the original code but I think this is the nature of more complex switch statements. ------------- Marked as reviewed by alanb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/4285
